Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eni-max-pods.txt #2057

Merged
merged 1 commit into from
Jan 11, 2025
Merged

Update eni-max-pods.txt #2057

merged 1 commit into from
Jan 11, 2025

Conversation

github-actions[bot]
Copy link
Contributor

Generated by aws/amazon-vpc-cni-k8s:

make generate-limits

@github-actions github-actions bot added the changelog/exclude Exclude this PR from future changelog entries. label Nov 16, 2024
@cartermckinnon
Copy link
Member

cartermckinnon commented Nov 16, 2024

Looks like g3's are on the way out. Holding for now, because accounts currently using g3's should be able to launch them for a while longer.

@github-actions github-actions bot force-pushed the update-eni-max-pods branch 3 times, most recently from 490c0e1 to 40b7805 Compare November 22, 2024 00:23
@github-actions github-actions bot force-pushed the update-eni-max-pods branch 3 times, most recently from a99d509 to 58cbf69 Compare December 2, 2024 00:24
@github-actions github-actions bot force-pushed the update-eni-max-pods branch 3 times, most recently from fbe9dc8 to 4618f0d Compare December 5, 2024 00:23
@ndbaker1
Copy link
Member

ndbaker1 commented Dec 5, 2024

would it benefit us if the script was aware of the current values and ignored removals?

@github-actions github-actions bot force-pushed the update-eni-max-pods branch 5 times, most recently from 9399cd8 to 3ff6e06 Compare December 17, 2024 00:25
@ndbaker1
Copy link
Member

unrelated, need to trigger CI on a clean PR :)

/ci

Copy link
Contributor Author

@ndbaker1 roger that! I've dispatched a workflow. 👍

Copy link
Contributor Author

@ndbaker1 the workflow that you requested has completed. 🎉

AMI variantBuildTest
1.24 / al2success ✅success ✅
1.24 / al2023success ✅failure ❌
1.25 / al2success ✅success ✅
1.25 / al2023success ✅failure ❌
1.26 / al2success ✅success ✅
1.26 / al2023success ✅failure ❌
1.27 / al2success ✅success ✅
1.27 / al2023success ✅failure ❌
1.28 / al2success ✅success ✅
1.28 / al2023success ✅failure ❌
1.29 / al2success ✅success ✅
1.29 / al2023success ✅failure ❌
1.30 / al2success ✅success ✅
1.30 / al2023success ✅failure ❌
1.31 / al2success ✅success ✅
1.31 / al2023success ✅failure ❌

@github-actions github-actions bot force-pushed the update-eni-max-pods branch 2 times, most recently from 0246712 to ed22481 Compare December 19, 2024 00:24
@github-actions github-actions bot force-pushed the update-eni-max-pods branch 4 times, most recently from de4e82e to 1aba28b Compare January 8, 2025 00:23
@github-actions github-actions bot force-pushed the update-eni-max-pods branch 3 times, most recently from 2ed2376 to 45185c8 Compare January 11, 2025 00:23
@ndbaker1 ndbaker1 force-pushed the update-eni-max-pods branch from 45185c8 to 32a70c3 Compare January 11, 2025 07:43
Copy link
Member

@ndbaker1 ndbaker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manually removed the deletion of g3s in case we want to review it later

@ndbaker1 ndbaker1 merged commit 12b93b2 into main Jan 11, 2025
11 checks passed
@ndbaker1 ndbaker1 deleted the update-eni-max-pods branch January 11, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/exclude Exclude this PR from future changelog entries.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants